Skip to content

Simplify and fix slider widget code in brush HUD

Scott Petrovic requested to merge (removed):petrovic/slider-style-simplify into master

For some reason in breeze the sliders are pretty broken looking on the brush HUD. See screenshot...

brush-hud-issue

I went into kis_slider_spin_box.cpp and saw that file is a bit messy with all the specific style hacks. This patch does the following:

  1. Rip out all the style specific hacks (which fixes the brush hud display)
  2. Remove the "plastique" style references. I have yet to see that on any build...and the code that is supposed to add it in KisMain doesn't seem to do anything on any build I have ever done.

Test Plan

After doing these changes (on Ubuntu), I tested the sliders for the sliding ability. Up/down arrows, and editing values. This seemed to work/look ok in the following styles: Fusion Breeze Windows

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Scott Petrovic

Merge request reports