Skip to content

432328 macOS: Finder plugins must use the loader_path of Krita.app

Amy spark requested to merge lsegovia/krita:work/amyspark/fix-macos-rpath-plugins into master

Xcode is picking up Quazip's requirement of our own bundled zlib. Because the resulting plugins are not marked as executable, they are not fixed by osxdeploy.sh. Moreover, the executables lack a rpath at all.

This commit marks the plugins' executables as +x and specifies a rpath pointing to Krita's Frameworks folder. I also left an alternative option inside osxdeploy.sh, if it is required in the future.

BUG: 432328

Test Plan

Open the following AppImage (signed and notarized) and check it renders thumbnails and previews correctly.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports