Skip to content

Change the order of tool icons in icon creator [Ramón Miranda]

Agata Cacko requested to merge tymond/krita:tiar/ramon_tool_icons_order_change into master

This MR is made on behalf of Ramón Miranda.

Whole description (with pictures): https://docs.google.com/document/d/1NUukyAPf74B89hnGxqg_5oz5gBcRTv633OADGMlKgbU/edit

New Order for Preset icon Library This panel is really good. We have a good bunch of icons, HSV modification and so on. But what if we polish it a bit? No code effort required ;) Problem. When we want to create a new brush with the Preset Icon Library we may have an annoying feeling because the icons are not sorted.

My idea is simple and is done already. The user can’t see the icon’s names so we can modify them a bit just adding this nomenclature:

0x_0y_BrushName 0x used for Category like Pencil, Ink, Modifier.. 0y used for Order inside the Category.

This system is not perfect but good to preserve order even when we change the icon name because is really weird if the name is the same totally. With this little change we achieve user find the right icon faster. My Categories are these.

00 Erasers. Very representative and this is as Krita shows the brushes. First Eraser then paint. 01 Pencils. The Basic to make artwork. 02 Charcoals. They are similar to pencils. The feeling is they are rougher. 03 Pastels or dry media. All the dry media, like colored pencils, pastels, oil pastels, bars. 04 Ink. All related to ink. important for comic artists and that is a huge world. 05 Digital. Airbrush is here because it has buttons to push like stylus and result is similar. 06 Felt Pens. like copics, markers, and that kind of “ink”. 07 Oil & Acrylic. All the brushes. 08 WaterC. Special Watercolor mimic. 09 Blenders. No color. 10 Modifiers. Things that only are effective over already painted pixels. 11 Specials. Symbols to give extra info. Maybe Grid would be in the modifiers section? Considerations to use this specific order. Avoid too much Categories. i thin 11 is not too much. (Generic) Use the icons we already have. We don’t want to spend too much time in these kind of things. Round → Flat→ Rough From Small to big inside each category Visual relationship between all of them.

Overall order is: Sketching, Basic Coloring, Liquid Color Mix, Watercolor, Blenders and Special features as modifiers or symbols.

Also i think is good idea to have more icons so maybe to fill the gaps. That means to rename the icon names but this is not a problem since we use the system 0x_0y_BrushName

The capture show a test to include more variants. WIP.

Also this applies to Emblems. We could provide more emblems to fill the gaps. i use this for “ink rough” for example.

And this is the result. Easy and appealing for brush creators.

“Maybe”Bug report. When you use the icon creator in zoomed images (for example 566% as shown in the image) You get pixelated icon preview. Not good because it seems to lack quality. :(

Wishlist. Bigger size for Emblems. When we use a lot of brushes and use a “minimized” view for thumbnails i can’t barely see the emblem. Not a problem, but maybe more users feel this. Who knows. Not important.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy. - I'm not sure what about those added icons...
Edited by Scott Petrovic

Merge request reports