Skip to content

Enable LittleCMS's Fast Float plugin

Amy spark requested to merge lsegovia/krita:work/amyspark/enable-lcms-fast-float-plugin into master

This MR enables LittleCMS's fast float plugin.

To do so, it updates LittleCMS to 2.12, because previous versions would crash under certain circumstances if the fast float plugin was enabled: https://github.com/mm2/Little-CMS/commit/75bd87ec8d2bca9dfc766e8067c22a3d72e968a2

In my case, I got the crash while attempting to convert RGBA (65535, 0, 0, 65535) to sRGB while the plugin was enabled. This was because, for some reason, the plugin would think the alpha channel was at a 16MB offset, when it should be 4.

Additionally, toss in my SSE configure-time detection patch, since Marti's code relies on it being disabled via a header definition. Otherwise, the SSE codepaths will choke compilation on non-Intel platforms.

Test Plan

Build and run Krita on an Intel platform (any OS will suffice) and on an ARM platform (probably Android).

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

/cc @woltherav

Merge request reports