Skip to content

Remove usages of QUrl in KisDocument API

Sharaf Zaman requested to merge szaman/krita:sh-zam/refactor-qurl into master

Test Plan

Wherever I could I used semantic helpers to help refactor/rename something. So, things behind #ifdef would not get refactored by this method. We need to verify that compilation works on all platforms.

The only API which still uses QUrl -> QString (vice-versa) is KRecentFilesAction, because there were a number of ifdefs for Windows related to QUrl. I felt this might need second thought.

Formalities Checklist

  • I confirmed this builds.
    • Linux
    • Windows
    • MacOS
    • Android
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (yes, I did verify that this broke none)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Sharaf Zaman

Merge request reports