Skip to content

fix detach canvas toggle

reinold rojas requested to merge reinoldrojas/krita-archive:reinoldrojas/fix-detach-canvas-toggle into master

Fixes the "Detach Canvas" bug reported in bugs.kde.org here. Now if you close the canvas window by clicking the window button the "Detach Canvas" toggle will be unset as well.

Test Plan

  1. Go to View -> Detach Canvas
  2. Go to View and confirm Detach Canvas is set
  3. Close the detached canvas using the window button
  4. Go to View and observe Detach Canvas is unset

I've also checked that the closing canvas window by toggling Detach Canvas still works.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by reinold rojas

Merge request reports