Skip to content

Redesign the flow of the Bundle Manager

Amy spark requested to merge lsegovia/krita:work/amyspark/dlg-bundle-manager-layout into master

This MR reworks the Bundle Manager to take advantage of grid and form layouts. Previously, every panel had a two-level nested VBox/HBoxLayout, which together with the lack of a minimumSize, prevented automatic adjustment.

This version has automatic stretch on the bundle list, gridding and automatic stretch on the button bar, and the bundle metadata laid out as a form. Additionally, I reused the GroupBox title to show the bundle name.

Both panels (and their inner components) have the margin set to 0 in order to not duplicate empty space.

Before After
Captura_de_pantalla_2021-03-26_232802 Captura_de_pantalla_2021-03-26_231643

Test Plan

Build Krita.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

/cc @woltherav /cc @tymond

Merge request reports