Skip to content

Use CMake to retrieve translations

Amy spark requested to merge lsegovia/krita:work/amyspark/translations into master

This MR retries, with a bit of 🍵, !769 (merged). It seems CMake isn't exactly transparent when it comes to documenting execute_process...

This reverts commit bb8bef26. This reverts commit fa3e90a3.

Test Plan

Build Krita. Check that, if you do not have a po directory, the configure process gets interrupted and the translations are downloaded. Also verify that this does not happen if your system lacks Git, Python or Subversion.

Tested on Windows and Linux with their respective CI scripts.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Amy spark

Merge request reports