Skip to content

Bugfix: Inconsistent stroke fill and shape fill

Sharaf Zamanrequested to merge
szaman/krita:bug-inconsistent-fillconfigwidget into master

Problem: Embedding KoFillConfigWidget in KoStrokeConfigWidget created codepaths which KisAcyclicSignalConnector doesn't block, which resulted in an inconsistent behavior when both strokes and fill were used in a shape.

Solution: By default if we hadn't embedded the widgets, signals from ResourceManager would've been blocked by KisAcyclicSignalConnector when we entered slotProposeCurrentColorToResourceManager. Since we don't, we have to manually block events when we are in this method.

PS: szaman/krita@0d8b9bd9 doesn't contribute to the bugfix. I refactored this while trying to get a picture of the behavior in my head and previous names were too confusing for me.

Test Plan

BUG:399127,422204,434828

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports