Skip to content

Bugfix: problems with transforming mirrored/flipped shapes

Sharaf Zaman requested to merge szaman/krita:bug-resizing-shape into master

The handle (called Direction in constructor) we get from DefaultTool is based on KoSelection of a shape. When we extract shape and operate on it, the transformation applied on it map the handles incorrectly. This doesn't happen until the shape is flipped where then the bounding box of the shape and KoSelection no longer map to same points (they map to the opposites).

Test Plan

  1. Create a vector shape
  2. Flip about a point using Select Shapes Tool
  3. Use the same point

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports