Skip to content

Fix more slider step disparities between 4.4.3 and master

R. B. requested to merge (removed):slidersteps into master

This merge request is an extension of commit 3dcd08f3, fixing most of the slider step disparities I could find.

Specifically:

  • Freehand Brush Tool Weighted - Adjusted Distance steps from 1 to 0.1 and Stroke Ending steps from 1 to 0.01

  • Liquify Tool - Adjusted Amount and Flow steps from 1 to 0.01

  • Gradient Tool - Adjusted Anti-alias threshold steps from 1 to 0.001

  • Performance tab - Adjusted Pool Limit and Undo Limit steps from 1 to 0.01

  • Edge Detection Filter - Adjusted Radius steps from 1 to 0.01

  • Height to Normal Map Filter - Adjusted Radius steps from 1 to 0.01

  • Phong Bumpmap Filter - Adjusted Reflectivity steps from 1 to 0.01

  • Text Brushtip - Adjusted Spacing steps from 1 to 0.01

  • Pattern options - Adjusted Scale, Brightness, Contrast, and Neutral Point steps from 1 to 0.01

Along with some other minor slider fixes.

What I did not change:

  • Freehand Brush Stabilizer Distance - In stable, steps are 0.1. In master, Distance is instead Sample Count, which has integer precision.
  • Predefined Brush Tip Size - In stable, steps are 0.01, but steps of 1 in master aligns with autobrush size steps and the toolbar size slider.
  • Liquify Size - See above.
  • Unsharp Mask Amount - In stable this is just a spinbox with steps of 0.10, but the steps of 0.20 in master seems explicitly set by Sachin Jindal's filter slider patch.

Todo

  • Fix disparities in sliders of less common brush engines, including all of the strength sliders in the MyPaint engine...

Test Plan

Take steps with a particular slider using the mousewheel or clicking the arrow buttons. Hold ctrl to increase strength of steps.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by R. B.

Merge request reports