Skip to content

Fix failure of the cli "--export" command on Windows.

Georg Kamptner requested to merge geok/krita:geok/FixWinCLI into master

Fixed the random failure of the command "krita test.kra --export --export-filename test.png" on Windows OS caused by try_lock() failing on the document image file.

The genesis of the fix can be found here: https://krita-artists.org/t/krita-api-commandline-interface/23128

It is a simple timing based fix (QThread::msleep(2);). A logic based fix might be more desirable.

Test Plan

Execute the command "krita test.kra --export --export-filename test.png". Previously this failed about 9 of 10 times on windows. Now it suceeds.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports