Skip to content

Show message in case of recorder failed to write a frame

Dmitrii Utkin requested to merge (removed):dmitriiutkin/434270-recorder-fixes into master

Show message in case of recorder failed to write a frame Block export and show extended description when FFMpeg couldn't be detected

BUG:434270

Test Plan

Frame Write failure:

  • Start recorder and make partition full (of just make symlink to the file with next number in recording directory to /dev/full)
  • The message box with description recorder is stopped must appear after specified amount of seconds when you try to continue drawing.

FFMpeg detection:

  • Uninstall ffmpeg (or just rename it's executable).
  • Open export dialog, the Export button must be disabled, ffmpeg location box should display text "[NOT FOUND]", also when you hover mouse on the X mark to the right side of text box error description hint must appear.
  • Install ffmpeg (or rename it) back
  • Make sure button works and path displayed correctly

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports