Skip to content

Fix stroke ignoring alpha lock sometimes.

Victor Moraes requested to merge vemora/krita:vemora/alphalock_amnesia into master

The function to resume a suspended stroke job didn't read the channel flags, so I added two lines to do that. This should hopefully solve a bug which makes strokes ignore 'preserve alpha' options. This bug happens rarely at random and I wasn't able to find it in the bug tracker.

Test Plan

I don't know why the strokes were getting suspended to begin with, although I have only observed that happening when instant preview was turned on. If there is a way of suspending/resuming them on command, then doing that when drawing with 'preserve alpha' on (either on the brush or the layer) should not draw on transparent pixels anymore.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports