Skip to content

Restore previous behaviour of brush editor popup; add option to detach brush editor as a dialog

Alvin Wong requested to merge alvinwong/krita:alvin/brush-editor-popup into master

This attempts to restore the previous behaviour of the brush editor popup that acts like a drop-down. In addition, a toggle to detach the brush editor popup as a dialog is added.

This adds one new string ("Detach Brush Editor").

I just placed the detach button on a random place that doesn't require changing the layout too much. Feel free to change it later.

image

Test Plan

  • Default state should be non-detached. Clicking on the brush editor tool icon or F5 shall show the brush editor as a drop-down popup.
  • Enabling "Detach Brush Editor" shall cause the brush editor to show as a dialog, which stays visible until the close button or Esc is pressed.
  • Disabling "Detach Brush Editor" shall cause the brush editor to show as a drop-down popup.
  • Clicking on the brush editor tool icon or F5 shall show the brush editor in its previous state.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports