Skip to content

Fix incorrect indexing in KisResourceIterator

Alvin Wong requested to merge alvinwong/krita:alvin/res-iter-fix into master

Fix the index handling in KisResourceIterator. To align with Qt Java-style iterators, currentIndex = 0 should mean before the first element, and currentIndex = count() should mean after the last element.

This fixes the "Workspace" menu (under "Window" main menu) listing skipping the first workspace (which is probably "Animation"), which is populated in KisMainWindow:2533 and currently the only user of KisResourceIterator.

Test Plan

  • The "Workspace" menu should match the list in the "Choose workspace" popup.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • n/a I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports