Skip to content

Fix setting 'modified' state to readonly documents

Agata Cacko requested to merge tymond/krita:tiar/fix_setting_readonly_doc_to_modified into master

Fix setting 'modified' state to readonly documents

Before this commit, the readonly documents would accept first setModified(true) call, but then ignore setModified(false) call because "it's read-only so it cannot be modified". That's because it was checking d->modified (current state) instead of mod (the desired state). That caused gamut masks (which are marked read-only) to ignore setModified(false) call and ask the user to save the document

Test Plan

  1. Open Gamut Mask docker.
  2. Try to create a new gamut mask.
  3. Make a few shapes.
  4. Try to save the mask using the Save button in the Gamut Masks docker. It should not ask you to save the file anywhere.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports