Skip to content

Fix video export wrongly using localized toString on QTime

Alvin Wong requested to merge alvinwong/krita:alvin/tostring-locale into master

QTime::toString() uses the system locale in Qt 5. When producing arguments for ffmpeg, we shall specify the C locale instead.

Fixes: https://bugs.kde.org/show_bug.cgi?id=430910

Note: A cursory search seem to reveal other code using QTime/QDate/QDateTime::toString in a similar manner. They might also require fixing.

Test Plan

Set system locale to one that produces special numerals for time and try rendering an animation with audio.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports