Skip to content

Make KisPopupButton a QToolButton instead of QPushButton

Alvin Wong requested to merge alvinwong/krita:alvin/popup-button-style into master

Make KisPopupButton inherit from QToolButton instead of QPushButton, so that we can get the autoRaise style instead of flat style, to make the styling on the toolbar more consistent.

simplescreenrecorder-2021-06-15_16.11.08.mkv

Test Plan

Verify that the popup buttons on the toolbar has the same autoRaise (hover feedback) style as the other tool buttons.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • n/a I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports