Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Bugzilla
    • Bugzilla
  • Merge requests 73
    • Merge requests 73
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GraphicsGraphics
  • KritaKrita
  • Merge requests
  • !916

Added a QLabel for color preview to KisHexColorInput

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged As Sa requested to merge ffwqo/krita:ffwqo/ColorPreviewOnSpecificColorSelector into master Jun 17, 2021
  • Overview 8
  • Commits 3
  • Pipelines 2
  • Changes 3

According to https://krita-artists.org/t/specific-color-selector-color-preview-idea/14461 it would be nice to see the color when using the specific color selector. I added it to KisHexColorInput::KisHexColorInput via a QLabel and update the color via setStyleSheet in the update method. Not sure if that was the right place for it but it was the only way I could figure out how to place the label directly beside the input box. I believe it is working correctly with the specified color models RGB, CMYK, etc.

image image image

Test Plan

(Tell us how to test the changes you made.)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited Aug 26, 2021 by Halla Rempt
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ffwqo/ColorPreviewOnSpecificColorSelector