Skip to content

423389 TIFF: support signed integer formats

Amy spark requested to merge lsegovia/krita:work/amyspark/423389 into master

This MR enables support for signed integer TIFF files.

I've not been able to resize, trim, or generate a signed integer image using ImageMagick or Pillow, hence I've not added a test to the suite. (Please feel free to push such an addition to the MR!)

BUG: 423389

Test Plan

Load the file attached in the bug report. Check that it displays as a grayscale image.

Before After
Captura_de_pantalla_de_2021-06-26_15-58-32 Captura_de_pantalla_de_2021-06-26_16-01-33

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports