Skip to content

Use translation of unnamed (‘Untitled’) colours

Karl Ove Hufthammer requested to merge (removed):translate-untitled-colours into master

All of the colour palettes included in Krita that have unnamed colours, have actually the colour names set to ‘Untitled’ in the .gpl files, instead of having empty names (I’m not sure it’s valid to have empty names, though). So the code that tried to show unnamed colours as the translation of the string ‘Untitled’, did not succeed. Now, colours with empty names or the name ‘Untitled’ are treated the same, so that the i18n() call always succeeds for unnamed colours.

Test Plan

  1. Start Krita in a non-English language that has complete translations (e.g. Norwegian Nynorsk).
  2. Choose a colour palette with unnamed colours (e.g. ‘Concept-cookie’) in the colour palette docker.
  3. Observe that the colour names are shown as the translation of the word ‘Untitled’.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports