439116 GMic: consistency updates
This MR makes a few changes to our patch of GMic-Qt:
- Disable its theming support when the host is Krita
- Disable internet access by default
- Fix on-launch update (if enabled) on slow connections
Tested on Windows with MSVC.
Test Plan
Build Krita and its plugin(s). Test:
- the Theme groupbox in GMic's settings is disabled, and that Krita's theming is not affected by launching GMic.
- GMic does not connect to the network on a clean install of Krita.
- if Internet access is enabled, and updates are enabled, launch GMic and check that it does not prematurely (after 4 seconds exactly) return an update error ("Filter definitions could not be updated").
Formalities Checklist
-
I confirmed this builds. -
I confirmed Krita ran and the relevant functions work. -
I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!) -
I made sure my commits build individually and have good descriptions as per KDE guidelines. -
I made sure my code conforms to the standards set in the HACKING file. -
I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.