Skip to content

Load translations for .ui files in Python plugins

Alvin Wong requested to merge alvinwong/krita:alvin/python-plugin-ui-i18n into master

This installs a KLocalizedTranslator specifically to load translations for the .ui files in Python plugins. These UI files must also use the class name pykrita_plugin_ui in order for it to work.

While implementing this change, I also noticed that the selectionsbagdocker plugin isn't installed during the build, but fixing it is out of scope of this change.

BUG: 407110

Test Plan

  • Check that the script starter plugin UI is translated
  • Add install_pykrita_plugin(selectionsbagdocker) to plugins/python/CMakeLists.txt, build and check that this docker is translated

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • n/a I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports