Skip to content

MSVC: build warning fixes

Amy spark requested to merge lsegovia/krita:work/amyspark/msvc-incremental-compile-fixes into master

The two commits in this MR fix a couple warnings (or potential spurious build failure) that I ran into while building with MSVC.

  • The first is a race condition between kritarunner and kritarunner_com executable targets; MSBuild compiles, generates code, then links, and if kritarunner(_com) generates its library export file before the other links, the link will fail with no clear explanation.

  • The second removes qrc compilation warnings that break incremental compilation (qml.qrc references two files that are directories instead).

Test Plan

Build Krita in Linux and with MSVC.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports