Skip to content

Delete resource by index from model, instead of selection index

Lucid Sunlight requested to merge awakening/krita:bug-439594 into master

Deleting a resource with "Show deleted resources" disabled will update the proxy model and next index in selection now points at wrong item, collect KoResource pointers first, and then fetch its index from model instead collect resource ids first, and then fetch resource index from model by id instead.

BUG:439594

Test Plan

  • Open Manage Resources window
  • Switch to Gradients
  • Make sure Show deleted resources is unchecked
  • Select first three items
  • Delete them
  • Observe that first three items were deleted, instead of first, third and fifth items

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Lucid Sunlight

Merge request reports