Skip to content

win: Work around touch docker buttons triggering twice

Alvin Wong requested to merge alvinwong/krita:alvin/touch-docker-input-fix into master

Hack around the issue by blocking certain mouse events in the touch docker.

Since I don't expect upstream to be able to come up with a fix soon, I think it's best for us to work around the issue for now.

See also: https://bugreports.qt.io/browse/QTBUG-95058, https://bugs.kde.org/show_bug.cgi?id=437196

BUG: 437196

Shall be cherry-picked to 5.0

Test Plan

  1. Shake the pen hovering on the canvas
  2. Press the touch docker buttons with touchscreen at the same time
  3. Repeat and check that the touch docker commands didn't fire twice in a row.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • n/a I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports