Skip to content

Bugfix: Fix sync problem between resource and shape

Sharaf Zaman requested to merge szaman/krita:bug-438758-fillconfigwidget into master

Prior to the change both the stroke widget and the fill widget were enabled at the same time and KoFillConfigWidget being embedded inside KoStrokeConfigWidget resulted in some code paths which could only be prevented with the use of signal blockers. But this created other problems like painttopbox's color not being in sync with the shape.

With this change we only make one widget active at a time. But add the capability in KoFillConfigWidget to change both the background and foreground color of image if resource manager requests so.

Test Plan

bug 438758 and verify no regression in bug 399127

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports