Skip to content

Fixed Regression: Allow odd sizes for animation export

Know Zero requested to merge knowzero/krita:KnowZero/animation-export-size-fix into master

Initially, a patch was done that rounded animation export to even sizes to prevent mp4/mkv crashes. Since then, mustHaveEvenDimensions has been implemented specifically for mp4/mkv to round the dimensions.

This patch removes the old duplicate code, and allows other formats that are not mp4/mkv to export to odd sizes.

Test Plan

  1. Make an animation with an odd width/height or both.
  2. Export the animation in any format that is not mp4/mkv, the odd file dimensions should remain
  3. Export the animation in mp4 or mkv, the dimensions of the resulting file should be properly rounded

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports