Skip to content

425832 TIFF & JPEG: handle Exif orientation

Amy spark requested to merge lsegovia/krita:work/amyspark/425832 into master

TIFF never handled it at all; JPEG has two cases that are broken:

  • ORIENTATION_TOPRIGHT
  • ORIENTATION_BOTLEFT

These were corrected and checked against Windows thumbnails and macOS's CGImage documentation.

BUG: 425832

Test Plan

Build Krita and

  • Open the attached files and check that all map to the TOPLEFT (suffix _1) orientation.
  • Run kis_tiff_test and kis_jpeg_test.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports