The source project of this merge request has been removed.
Fix memory leaks in _synctex_decode_string
The top issue reported by code quality scanner (Critical - Common realloc mistake: 'string' nulled but not freed upon failure (CWE-401); look at any recent pull request e.g. !1061 (closed))
-
reallocdoes notfreethe previous string when returningNULL. - The code after
realloccan go tomore_characters, which may return an error without freeing the string.
The bigger question is: why Okular maintains its own copy of synctex? Why not simply include https://github.com/jlaurens/synctex as a Git submodule? Patches in core/synctex/patches/ can be upstreamed (if they are still relevant).