Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Okular Okular
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 67
    • Merge requests 67
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GraphicsGraphics
  • OkularOkular
  • Merge requests
  • !141

Create Color Mode Menu

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged David Hurka requested to merge davidhurka/okular:create-colormode-menu into master Mar 16, 2020
  • Overview 27
  • Commits 7
  • Pipelines 11
  • Changes 11

This adds a Color Mode submenu to the View menu. It makes the Change Colors feature of Okular easier to use.

The menu is a ToggleActionMenu, so it can be plugged into the toolbar.

The toolbar button will always show the last selected color mode, except Normal Colors, so the Change Colors feature can be toggled by just clicking it. It also toggles when the selected action in the menu is selected again. But since Qt 5.14 introduced ExclusiveOptional mode for QActionGroup, this is probably an accepted UI behaviour.

This is originally taken from D21195.

BUG: 407217

Screenshot:

Screenshot_20200901_004734

TODO

(In other patches, less important if this does not go to the View menu)

  • Add icons for all color modes, see frameworks/breeze-icons!22 (merged)
    • [ ] Get OverlayIconEngine working, see !223 (closed)
    • Merge createColorIcon, see !256 (merged)
  • If possible, drastically improve rendering performance, until the warning in the config dialog can be removed.
  • View menu submenu?
Edited May 28, 2021 by David Hurka
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: create-colormode-menu