Skip to content

Use the term "Annotations" everywhere in place of "Reviews"

Simone Gaiarin requested to merge gaiarin/okular:fix-186797 into master

The term "Reviews" is still used in the code, but not anymore in the UI.

This is a grep of the codebase with the locations where "Reviews" is still used

conf/okular.kcfg: <group name="Reviews" >
conf/okular.kcfg:  <entry key="ReviewsSearchCaseSensitive" type="Bool">
conf/okular.kcfg:  <entry key="ReviewsSearchRegularExpression" type="Bool">
part.h:class Reviews;
part.h:    QPointer<Reviews> m_reviewsWidget;
okular.upd:Group=Reviews
okular.upd:Group=Reviews
ui/side_reviews.cpp:Reviews::Reviews(QWidget *parent, Okular::Document *document)
ui/side_reviews.cpp:    connect(m_searchLine, &KTreeViewSearchLine::searchOptionsChanged, this, &Reviews::saveSearchOptions);
ui/side_reviews.cpp:    connect(groupByPageAction, &QAction::toggled, this, &Reviews::slotPageEnabled);
ui/side_reviews.cpp:    connect(groupByAuthorAction, &QAction::toggled, this, &Reviews::slotAuthorEnabled);
ui/side_reviews.cpp:    connect(curPageOnlyAction, &QAction::toggled, this, &Reviews::slotCurrentPageOnly);
ui/side_reviews.cpp:    connect(expandAll, &QAction::triggered, this, &Reviews::slotExpandAll);
ui/side_reviews.cpp:    connect(collapseAll, &QAction::triggered, this, &Reviews::slotCollapseAll);
ui/side_reviews.cpp:    connect(m_view, &TreeView::activated, this, &Reviews::activated);
ui/side_reviews.cpp:    connect(m_view, &TreeView::customContextMenuRequested, this, &Reviews::contextMenuRequested);
ui/side_reviews.cpp:Reviews::~Reviews()
ui/side_reviews.cpp:void Reviews::notifyCurrentPageChanged(int previousPage, int currentPage)
ui/side_reviews.cpp:void Reviews::reparseConfig()
ui/side_reviews.cpp:void Reviews::slotPageEnabled(bool on)
ui/side_reviews.cpp:void Reviews::slotAuthorEnabled(bool on)
ui/side_reviews.cpp:void Reviews::slotCurrentPageOnly(bool on)
ui/side_reviews.cpp:void Reviews::slotExpandAll()
ui/side_reviews.cpp:void Reviews::slotCollapseAll()
ui/side_reviews.cpp:void Reviews::activated(const QModelIndex &index)
ui/side_reviews.cpp:QModelIndexList Reviews::retrieveAnnotations(const QModelIndex &idx) const
ui/side_reviews.cpp:void Reviews::contextMenuRequested(const QPoint pos)
ui/side_reviews.cpp:    connect(&popup, &AnnotationPopup::openAnnotationWindow, this, &Reviews::openAnnotationWindow);
ui/side_reviews.cpp:void Reviews::saveSearchOptions()
ui/side_reviews.cpp:    Okular::Settings::setReviewsSearchRegularExpression(m_searchLine->regularExpression());
ui/side_reviews.cpp:    Okular::Settings::setReviewsSearchCaseSensitive(m_searchLine->caseSensitivity() == Qt::CaseSensitive ? true : false);
ui/side_reviews.h:class Reviews : public QWidget, public Okular::DocumentObserver
ui/side_reviews.h:    Reviews(QWidget *parent, Okular::Document *document);
ui/side_reviews.h:    ~Reviews() override;
part.cpp:    // [left toolbox: Reviews] | []
part.cpp:    m_reviewsWidget = new Reviews(nullptr, m_document);
part.cpp:    connect(m_reviewsWidget.data(), &Reviews::openAnnotationWindow, m_pageView.data(), &PageView::openAnnotationWindow);
part.cpp:    // update Reviews settings

BUG: 186797

FIXED-IN: 20.12.0

Merge request reports