Make the CI pass with new clang-tidy (!336) · Merge requests · Graphics / Okular

Albert Astals Cid requested to merge work/aacid/okular_ci_clangtidy into release/20.12 Dec 09, 2020

Disable bugprone-suspicious-include since it's triggered by the moc includes

Disable bugprone-reserved-identifier since it's triggered by all our _OKULAR defines, and yes even if the spec says that underscore is reserved, are we going to be that unlucky that the library decides to start using _OKULAR ? not probably

Add two TODOs for the future to make NormalizedRect/Point faster

Silence a warning about a quick moving QString if we make it non const

Silence a uchar vs char warning that is in decades old code so experience seems to suggest it's ok.

Make the CI pass with new clang-tidy

Merge request reports