Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Okular Okular
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 55
    • Merge requests 55
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GraphicsGraphics
  • OkularOkular
  • Merge requests
  • !347

Fix opening markdown files

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Albert Astals Cid requested to merge work/aacid/430538 into release/20.12 Dec 19, 2020
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 1

In d2ae2c28 we introduced a tweak that broke opening markdown files.

what we really want is this:

  • If the mimetype from the filename is text (or children) but looking at the data says it's not text, then try opening first opening with the data suggeted mimetype
  • But if the data suggested mimetype says it's text, use the filename suggested mimetype since for example, the only way to really differentiate markdown from text is the filename, so trust that

BUGS: 430538

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/aacid/430538