Skip to content

Remove unnecessary copying from paintCroppedPageOnPainter

Max Mueggler requested to merge stapledbattery/okular:optimizations into master

PagePainter::paintCroppedPageOnPainter had a few calls to QPixmap::setDevicePixelRatio on pixmaps it does not own, which detaches the pixmap, making a deep copy. It turns out these were all unnecessary. It also copied scaled before drawing them onto the painter.

I've tested all the changes except for the annotation stamps, which I'm just assuming works like the others.

Bug: https://bugs.kde.org/show_bug.cgi?id=460681

Edited by Oliver Sander

Merge request reports

Loading