Skip to content

Fix silently dismissing user defined errors

Daniel Lanz requested to merge mydayyy/spectacle:fix_silent_errors into master

All user defined errors were silently dismissed, since error was passed on as a boolean instead of an integer, so no differentiation could be made anymore down the line.

This fix correctly dismisses a cancelled share without an error message but brings back the red indicator together with the error message when an user defined error was raised by a share plugin.

This will bring the back the red indicator when an error is raised which was not reachable in the code anymore: Screenshot_20220412_233755

All tests are passing:

Test project /home/mydayyy/kde/build/spectacle
    Start 1: appstreamtest
1/2 Test #1: appstreamtest ....................   Passed    1.02 sec
    Start 2: filename_test
2/2 Test #2: filename_test ....................   Passed    0.06 sec

100% tests passed, 0 tests failed out of 2

Total Test time (real) =   1.08 sec

BUG: 452558

Merge request reports