Skip to content

Add controls to RecordingView, move flickable to ScreenshotView, Make recordedTime update more reliably

Noah Davis requested to merge work/ndavis/recording-ui into master

11d01c37: VideoPlatform: Make the value of recordedTime update more reliably

The value didn't always update as consistently and frequently as it should have. It's still not completely perfect since sometimes the duration of the finished video is slightly different from the recorded time indicated while recording.

Switched from using QDateTime to QElapsedTimer because using QDateTime to get the time since something happened can be problematic if the user changes their computer's time.

Used a QBasicTimer instead of a QTimer because it's slightly more efficient and not really any more work in this case.

7bd7e3ae: add timeFromMilliseconds(), move recordedTime formatting to SpectacleCore

c482c649: Move the scrollable/zoomable view from ImageView to ScreenshotView

It's only really needed for image annotating. No need to load it when doing things with videos and it keep the code together.

06dbc7cc: RecordingView: Add controls

Short video. Trying really hard to stay under the 10MB limit.

Screencast_20230217_072952-1

@teams/vdg for the UI, @apol for the bit touching the video backend

Edited by Noah Davis

Merge request reports