Skip to content

Fix quitting Spectacle with Escape affecting windows below it

Noah Davis requested to merge work/ndavis/quit-escape into master

Previously, if you pressed Escape to close Spectacle when a fullscreen video in Firefox was underneath, the release of Escape would also cancel the fullscreen state of the video. Basically, Spectacle was no longer there to accept the Escape release event, so it went to Firefox.

I think this is fundamentally an upstream issue in Qt, KWin or X11 (intentional or not), but we're fixing it here because we can. What and where the correct upstream behavior should be is also a complex and highly debatable topic.

BUG: 428478

How to test:

  1. Open a youtube video in firefox and make it fullscreen
  2. Press PrintScreen to bring up spectacle.
  3. Open the settings dialog.
  4. Press Escape to quit the settings dialog.
  5. Press Escape to quit Spectacle.

The settings dialog should quit without affecting Spectacle and Spectacle should quit without affecting Firefox.

Edited by Noah Davis

Merge request reports