Skip to content

Draft: Implement useStroke/useFill based on dedicated settings values rather than the fillColor

Stefan Mayer requested to merge hotzeplotz/spectacle:checkbox-fill-color into master

After !236 (merged), this MR implement the checkboxes based on a dedicated settings value for useStroke and useFill and adjust the defaults to draw a "frame" first.

Changes

  • Hide option values (strokeWidth, fillColor), when option is unchecked
  • Remove colon from label, when option is unchecked
  • Keep always the selected fillColor, so a semi-transparent color could also toggled.
  • Draw shadow independently, currently shadow needs one of stroke or fill.
  • Add checkboxes for stroke and fill only for Rectangle, Ellipse and Number
  • Do not provide checkbox for "noStroke" for shapes that rely on a stroke. Highlight, Line, Freehand, Arrow
  • Set defaults to draw "frame" first with common default color red
    • (rectangle|ellipse)Shadow: true
    • (rectangle|ellipse)StrokeWidth: default: 2, min: 1
    • (rectangle|ellipse)StrokeColor: red
    • (rectangle|ellipse)UseStroke: true
    • (rectangle|ellipse)UseFill: false
    • (rectangle|ellipse)FillColor: red

rm ~/.config/spectaclerc

spectacle-checkbox-unfilled-5

Edited by Stefan Mayer

Merge request reports