Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Spectacle Spectacle
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GraphicsGraphics
  • SpectacleSpectacle
  • Merge requests
  • !24

Respect settings and cli parameters

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Antonio Prcela requested to merge aprcela/spectacle:B425573 into master Oct 02, 2020
  • Overview 9
  • Commits 1
  • Pipelines 0
  • Changes 2

This change affects that spectacle respects both the settings and CLI parameters. The two bugs that get fixed, have the same issue. But they are activated on two different ways, one via CLI other via GUI. Copy image to clipboard and save to file were in one if (SpectacleCore.cpp L319). Which didn't allow to have the image both saved to the clipboard and as a file.

Fix for:

  • Bug 425573: https://bugs.kde.org/show_bug.cgi?id=425573 "Spectacle does not save file in background mode"
  • Bug 422148: https://bugs.kde.org/show_bug.cgi?id=422148 "Respects settings only when the spectacle window is opened"
Edited Oct 05, 2020 by Antonio Prcela
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: B425573