Skip to content

Show magnifier when holding Shift and use magnifier locations

Noah Davis requested to merge work/ndavis/keyboard-magnifier into master

You can now get the magnifier while using arrow keys to modify the selection or hovering by holding Shift. The magnifier tries to keep its location close to where the mouse was, the last handle you dragged with the mouse or the corner closest to the last part of the selection that was modified.

The magnifier is only shown now while Shift is held and the "Show magnifier" setting is enabled, but I'm not actually that happy with this behavior even if it seems more accurate to what the UI says. I think I want to make the setting toggle between always showing while modifying the selection and only showing while shift is held.

Behavior I want feedback on:

Should the "Show Magnifier" setting in the config dialog be for always showing a magnifier when changing the selection or should it be for showing the magnifier at all?

Should pressing Shift show the magnifier only while pressing or should it toggle the magnifier?

BUG: 477399

Screencast_20231208_191503

Edited by Noah Davis

Merge request reports