Skip to content

SpectacleCore: take into account that X11 has many compositors

Konstantin Kharlamov requested to merge konstantink/spectacle:fix-rectangle-selection-visibility-master into master

Commit

efc267076 "Only have minimum 50ms timer if using PlatformXcb"

introduced a regression by making spectacle window visible at the moment of making rectangular screenshot. Before that commit timeout was being set to 50ms but afterwards it become set to 0. That happened because the commit didn't take into account that X11 KDE may be used with different compositors, such as Picom for example.

introduced a regression by making spectacle window visible at the moment of making rectangular screenshot. Before that commit timeout was being set to 50ms but afterwards it become set to 0. That happened because the commit didn't take into account that X11 KDE may be used with different compositors, such as Picom for example.

Ideally it would be possible to detect if the compositor in use is kwin. But there seems to be no API for that, so instead let's return back the check for X11 platform and add a comment on that.

BUG: 484652

CC: @ndavis the regressed commit author

Edited by Konstantin Kharlamov

Merge request reports