Skip to content

Port away from Qt5-only QWebEngineScriptCollection::findScript

Friedrich W. H. Kossebau requested to merge kossebau/kdevelop:work/kossebau/portfindscripts into work/igor/kf6

((stump branch in place of old commit))

Untested as currently there are no users of the methods StandardDocumentationView::setOverrideCssFile/Code(). See end of 60df20c0 commit message why they are kept around.

Original commit replaced just with a for loop over all the scripts returned.

    const auto oldScripts = scripts.find(scriptName);
    for (const auto &oldScript : oldScripts) {
        scripts.remove(oldScript);
    }

But it seems to me that given we know explicitly deal with possibly bad data we should also do some sanity check on it. Or would just a passive comment be preferred?

Merge request reports