- Apr 12, 2017
-
-
Albert Astals Cid authored
-
- Apr 05, 2017
-
-
Albert Astals Cid authored
-
- Mar 29, 2017
-
-
Elvis Angelaccio authored
Summary: Small regression in commit 68bb0ec2. We need to use the new (standard) name for the delete action, otherwise it won't be properly enabled/disabled. BUG: 378154 FIXED-IN: 17.03.90 Reviewers: emmanuelp Differential Revision: https://phabricator.kde.org/D5248
-
- Mar 27, 2017
-
-
This patch will cause a "New Window" command to open a new window with the URL from the active view. Opening a new instance via launcher will still open a new window with the URL specified in Startup settings. This is the behavior in Windows 10 file explorer. The advantage is this gives the user a way to open a new window with the current URL(New Window) as well as a new window with URL specified in Startup settings(new instance) whereas currently, there isn't an easy way to open a new window with the current URL. You'd have to either open a new window and copy and paste the URL, or open a new tab(which opens with the same URL) and detach it. I'd much rather have the new window open with the current URL and if what I wanted was the Startup URL I could easily get there as it's already bookmarked. REVIEW: 129973
-
- Mar 20, 2017
-
-
Albert Astals Cid authored
-
- Mar 15, 2017
-
-
Kai Uwe Broulik authored
KUser does quite a lot of stuff under the hood and also calls getpwuid which might block with network login. Differential Revision: https://phabricator.kde.org/D5049
-
- Mar 14, 2017
-
-
Kai Uwe Broulik authored
Differential Revision: https://phabricator.kde.org/D4498
-
Marco Martin authored
Summary: point the knsrc providers file to the new kde store, and port the servicemenuinstallation/servicemenudeinstallation scripts to kf5 (they still were based on kde4-config) BUG:376922 Test Plan: downloaded some service menus (send to telegram, convert svg) by the knewstuff ui available in the services page of config dialog they get installed in the proper folder and work, uninstall works Reviewers: #dolphin, emmanuelp Reviewed By: #dolphin, emmanuelp Subscribers: elvisangelaccio Differential Revision: https://phabricator.kde.org/D5035
-
- Mar 13, 2017
-
-
Elvis Angelaccio authored
Summary: It was introduced in kconfig 5.25 and it properly handles the shift+del shortcut (together with kxmlgui >= 5.30). This allows us to drop the custom delete shortcut as well as the shift+del workaround in DolphinMainWindow. Test Plan: Shift+Del still deletes files, without the 'ambiguous shortcut' warning dialog. Reviewers: emmanuelp Differential Revision: https://phabricator.kde.org/D5010
-
- Mar 12, 2017
-
-
Sergey Kalinichev authored
This reverts commit edf8e573. See https://git.reviewboard.kde.org/r/129662 for discussion
-
- Mar 10, 2017
-
-
Elvis Angelaccio authored
Summary: This improves the discoverability of the diskspace menu, a feature otherwise almost impossible to find. Reviewers: gregormi, emmanuelp Differential Revision: https://phabricator.kde.org/D4873
-
- Mar 08, 2017
-
-
Kai Uwe Broulik authored
Otherwise this results in the generic executable icon as bouncy cursor. Differential Revision: https://phabricator.kde.org/D4823
-
Kai Uwe Broulik authored
Instead of just assuming hidden files always start with a "." The items were already filtered out but when showing hidden files they weren't painted at reduced opacity. Differential Revision: https://phabricator.kde.org/D4978
-
- Feb 26, 2017
-
-
Summary: The current animation duration for smooth scrolling is 100 ms which feels as if there is no smooth scroll animation in the first place. Bumping this up to something like 300 ms seems to make the scrolling actually appear smooth. Also, based on diff comments the easing curve is set to InOutQuart. Test Plan: Built this change locally and tried scrolling a folder with many items both single step mouse wheel and also larger steps of the mouse wheel. Reviewers: elvisangelaccio, emmanuelp Reviewed By: emmanuelp Subscribers: htietze, colomar, andreask, emmanuelp, elvisangelaccio Differential Revision: https://phabricator.kde.org/D4560
-
- Feb 24, 2017
-
-
Script Kiddy authored
-
- Feb 20, 2017
-
-
David Edmundson authored
There is a bug that can happen in the following situation: - user right clicks to open a menu - that context menu grabs input - the QGrabphicsView also notes the mouse was pressed, but not that the mouse was released because it doesn't have mouse events any more - when a user clicks to dismiss the menu and then without moving clicks quickly again to send, we don't get another press event because the QGraphicsScene still thinks the mouse is pressed from the first time the context menu was shown and QGraphicsScenePrivate::lastMouseGrabberItemHasImplicitMouseGrab still points to the old object. This is a known bug in QGraphicsView and you can see QGraphicsScenePrivate::sendMouseEvent has a workaround to reset the lastMouseGrabberItemHasImplicitMouseGrab on mouse moves, with the comment: "This is a temporary fix for until we get proper mouse grab events." Realistically this isn't going to happen in QGraphicsView now. We do get a double click event though. By checking for double click events we can grab those missed clicks. It doesn't cause any other side effects because normally the context menu will fire after the first click and this rarely gets processed. REVIEW: 129960
-
- Feb 19, 2017
-
-
Emmanuel Pescosta authored
Basically a copy of commit kate/9adcebd3c2e476c8a32e9b455cc99f46b0e12a7e which was written by Martin Grässlin.
-
- Feb 18, 2017
-
-
Emmanuel Pescosta authored
-
The entries in this patch are very minimal and are as follows: apidocs - user generated doc doxygen.log - log from generating doc CMakeLists.txt.user - from Qt Creator .directory - created by dolphin REVIEW: 129865
-
REVIEW: 129662
-
The patch applies the shadow to all previews except for folders, fonts and Win32 exe/dll previews, similar to how Windows and MacOS handles it. REVIEW: 129918
-
Emmanuel Pescosta authored
that the selection can be changed after reloading of the current view. Otherwise it is not possible to alter the selection without restarting a new one. Bug found by Martin Tobias Holmedahl Sandsmark See also RR 128563
-
Emmanuel Pescosta authored
by saveState/restoreState.
-
Emmanuel Pescosta authored
Based on the idea of Martin Tobias Holmedahl Sandsmark
-
Emmanuel Pescosta authored
as stated in the documentation of KUrlNavigator::saveLocationState. The historyChanged signal of the KUrlNavigator is emitted before the urlChanged signal and so the view state restoring happens before the view URL has been changed. This makes it impossible to save and restore the selected URLs, because DolphinView::setUrl clears the list of selected items (which has been restored right before). This changes removes the history changed slot and restores the view state after the setUrl call.
-
- Feb 13, 2017
-
-
arnav dhamija authored
This adds the support for the Stash action which will be helpful for the upcoming stash:/ ioslave
-
arnav dhamija authored
-
arnav dhamija authored
-
arnav dhamija authored
-
arnav dhamija authored
-
Kai Uwe Broulik authored
Otherwise we might crash in applySettings() or restoreDefaults()
-
Kai Uwe Broulik authored
Differential Revision: https://phabricator.kde.org/D4501
-
arnav dhamija authored
-
arnav dhamija authored
-
- Feb 09, 2017
-
-
Elvis Angelaccio authored
Since commit 230fe13d this class is not a "tooltip" anymore, but just a simple widget. Rename it to avoid future confusion. Reviewers: emmanuelp Differential Revision: https://phabricator.kde.org/D4451
-
- Feb 08, 2017
-
-
Kai Uwe Broulik authored
If this KCM is disabled through KIOSK restriction opening it would result in an error message. Hide the entry altogether in this case. Differential Revision: https://phabricator.kde.org/D4502
-
- Feb 06, 2017
-
-
Kai Uwe Broulik authored
-
Kai Uwe Broulik authored
We can colorize icons based on the user's palette, so clear the pixmap cache when it changes. Differential Revision: https://phabricator.kde.org/D3937
-
- Feb 05, 2017
-
-
Elvis Angelaccio authored
KWindowSystem is no longer used since commit 230fe13d. It was only pulled for `KWindowEffects::enableBlurBehind()`, which is now in plasma-integration (triggered by KToolTipWidget).
-
Elvis Angelaccio authored
This is no longer needed since commit 230fe13d
-