Skip to content
Snippets Groups Projects
  1. Apr 12, 2017
  2. Apr 05, 2017
  3. Mar 29, 2017
  4. Mar 27, 2017
    • Don Nguyen's avatar
      behavior change -> New Window opens with same URL · 4de29ad9
      Don Nguyen authored and Albert Astals Cid's avatar Albert Astals Cid committed
      This patch will cause a "New Window" command to open a new window with
      the URL from the active view.  Opening a new instance via launcher will
      still open a new window with the URL specified in Startup settings.
      This is the behavior in Windows 10 file explorer.  The advantage is this
      gives the user a way to open a new window with the current URL(New
      Window) as well as a new window with URL specified in Startup
      settings(new instance) whereas currently, there isn't an easy way to
      open a new window with the current URL.  You'd have to either open a new
      window and copy and paste the URL, or open a new tab(which opens with
      the same URL) and detach it.  I'd much rather have the new window open
      with the current URL and if what I wanted was the Startup URL I could
      easily get there as it's already bookmarked.
      
      REVIEW: 129973
      4de29ad9
  5. Mar 20, 2017
  6. Mar 15, 2017
  7. Mar 14, 2017
  8. Mar 13, 2017
    • Elvis Angelaccio's avatar
      Port to KStandardAction::DeleteFile · 68bb0ec2
      Elvis Angelaccio authored
      Summary:
      It was introduced in kconfig 5.25 and it properly handles the shift+del
      shortcut (together with kxmlgui >= 5.30). This allows us to drop the
      custom delete shortcut as well as the shift+del workaround in
      DolphinMainWindow.
      
      Test Plan: Shift+Del still deletes files, without the 'ambiguous shortcut' warning dialog.
      
      Reviewers: emmanuelp
      
      Differential Revision: https://phabricator.kde.org/D5010
      68bb0ec2
  9. Mar 12, 2017
  10. Mar 10, 2017
  11. Mar 08, 2017
  12. Feb 26, 2017
    • Vishal Rao's avatar
      Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart · 58c5eae1
      Vishal Rao authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      The current animation duration for smooth scrolling is 100 ms which feels as if there is no smooth scroll animation in the first place. Bumping this up to something like 300 ms seems to make the scrolling actually appear smooth.
      
      Also, based on diff comments the easing curve is set to InOutQuart.
      
      Test Plan: Built this change locally and tried scrolling a folder with many items both single step mouse wheel and also larger steps of the mouse wheel.
      
      Reviewers: elvisangelaccio, emmanuelp
      
      Reviewed By: emmanuelp
      
      Subscribers: htietze, colomar, andreask, emmanuelp, elvisangelaccio
      
      Differential Revision: https://phabricator.kde.org/D4560
      58c5eae1
  13. Feb 24, 2017
  14. Feb 20, 2017
    • David Edmundson's avatar
      Work round missing right click event after dismissing a context menu · f72dadb0
      David Edmundson authored
      There is a bug that can happen in the following situation:
      - user right clicks to open a menu
      
      - that context menu grabs input
      
      - the QGrabphicsView also notes the mouse was pressed, but not that the
      mouse was released because it doesn't have mouse events any more
      
      - when a user clicks to dismiss the menu and then without moving clicks
      quickly again to send, we don't get another press event because the
      QGraphicsScene still thinks the mouse is pressed from the first time the
      context menu was shown and
      QGraphicsScenePrivate::lastMouseGrabberItemHasImplicitMouseGrab still
      points to the old object.
      
      This is a known bug in QGraphicsView and you can see
      QGraphicsScenePrivate::sendMouseEvent has a workaround to reset the
      lastMouseGrabberItemHasImplicitMouseGrab on mouse moves, with the
      comment: "This is a temporary fix for until we get proper mouse
      grab events."
      
      Realistically this isn't going to happen in QGraphicsView now.
      
      We do get a double click event though. By checking for double click
      events we can grab those missed clicks. It doesn't cause any other side
      effects because normally the context menu will fire after the first
      click and this rarely gets processed.
      
      REVIEW: 129960
      f72dadb0
  15. Feb 19, 2017
  16. Feb 18, 2017
  17. Feb 13, 2017
  18. Feb 09, 2017
  19. Feb 08, 2017
  20. Feb 06, 2017
  21. Feb 05, 2017
Loading