• Albert Freeman's avatar
    Custom background color · 1f6e8a47
    Albert Freeman authored
    Summary:
    BUG: 182994
    
    Adds an option to the config dialog that enables background color (the color around the displayed page) to be changed (while by default preserving the Qt toolkit selection as not to affect existing users).
    
    Reasons for this change:
    Accessibility, eye strain, aesthetic reasons, color displayed on monitor can affect power consumption (how: depends on display technology).
    Many people want this change occording to Bugzilla and other sources.
    
    Maintenance: Nearly no additional maintenance:
    This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular.
    
    {F4257766}
    
    Other less important information:
    https://git.reviewboard.kde.org/r/130219/
    https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html
    
    Test Plan:
    Tested everything, it all works:
    Toggled the custom background color, changed custom background color, removed okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual qt theme colour by default (where the settings file remembered the custom color).
    
    Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham
    
    Reviewed By: ngraham
    
    Subscribers: aacid, ltoscano, ngraham
    
    Tags: #okular
    
    Differential Revision: https://phabricator.kde.org/D8051
    1f6e8a47
dlggeneral.cpp 1.78 KB