Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KDevelop Python Support
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • KDevelopKDevelop
  • KDevelop Python Support
  • Merge requests
  • !11

Lock the DUChain when retrieving the declaration for a StructureType

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Jonathan Verner requested to merge verner/kdev-python:fix/444055-fix-locking-related-assert-crash into master Oct 19, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

The call to KDevelop::IdentifiedType::declaration requires the DUChain to be at least read locked, since it calls KDevelop::DUChain::chainForIndex, which is documented to require a read lock on the DUChain

The commit also removes a (slightly) related misdocumentation of Helper::resolveAliasDeclaration, which claimed to need a read lock while doing the locking itself.

BUG: 444055

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/444055-fix-locking-related-assert-crash