-
Friedrich W. H. Kossebau authored
Summary: VcsDiff and IBasicVersionControl::diff(...) many years ago got initial support for requesting and storing raw copies of files changed in a revision. Nothing in KDevelop though makes use of that feature, and all the VCS plugins themselves do not support it either, even ignore explicit requests. To ease maintainance of the used and working code for creating unified text diffs, this patch drops the dead code for that unfinished feature. When someone ever starts working on it again, the needed structures in VcsDiff can be easily readded and also done matching whatever approach is taken then. After the initial support was introduced in 2007 by e.g. commits 5ffc3c23 and 7b09fc2f no further related work was ever commited to the codebase. SvnDiffJob even has initial code for fetching full before-versions of the affected files. But this seems premature test code which accidentally got committed, as the full copies are always fetched and stored additionally to the unified diff, and without respecting the diff type parameter passed to the method. Also were the after-versions not stored, and no other code also has ever been fetching those full copies from the returned VcsDiff object. Worse, most other VCS plugins simply ignored the diff type parameter passed to the IBasicVersionControl::diff(...) method, and always returned a unified diff, rendering the type parameter useless. Reviewers: #kdevelop, apol Reviewed By: #kdevelop, apol Subscribers: kdevelop-devel Differential Revision: https://phabricator.kde.org/D8962
36fd6bf0