Skip to content

Connect to KJob signals with functor-based connection syntax

Igor Kushnir requested to merge igorkushnir/kdevelop:kjob-functor-based-syntax-connect into master

KJob::percent(KJob *job, unsigned long percent) signal is public since https://commits.kde.org/kcoreaddons/c0b312a41f7fcb42ac6251a2d194c7799dfac723 (since KF 5.46).

Simplify JobStatus implementation:

  • move slotPercent() from JobStatusPrivate to JobStatus for simplicity;
  • remove unused JobStatusPrivate::m_job data member.

ulong => unsigned long in PatchReviewToolView::testJobPercent() because "ulong" is practically absent from KDevelop source code now.

Merge request reports