Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
KDevelop
KDevelop
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 30
    • Merge Requests 30
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • KDevelop
  • KDevelopKDevelop
  • Merge Requests
  • !167

Merged
Opened Sep 22, 2020 by Igor Kushnir@igorkushnirDeveloper

Don't crash after Cancel in Job Already Running dialog

  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

When a user Execute-Launches an application a second time while the previously launched instance of this application is still running, the "Job Already Running" dialog appears with 3 buttons. If a user clicks the Cancel button, a NativeAppJob kills itself Quietly. This NativeAppJob belongs to an ExecuteCompositeJob, which is not notified when a subjob is killed Quietly. So the ExecuteCompositeJob keeps waiting for it to finish. When this waiting ExecuteCompositeJob is killed (e.g. via "Stop All" button or on KDevelop exit), it attempts to kill the subjob it believes is still running, but which in fact is long since destroyed. This usually causes a segmentation fault.

Aleix Pol fixed a similar crash when the "Kill All Instances" button in the "Job Already Running" dialog is clicked in 8430d305.

BUG: 399511, 416874

FIXED-IN: 5.6.1

Edited Sep 22, 2020 by Igor Kushnir
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: kdevelop/kdevelop!167
Source branch: job-already-running-cancel-crash-fix